Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructured Language Server Component #91

Merged
merged 14 commits into from
Sep 4, 2023
Merged

Restructured Language Server Component #91

merged 14 commits into from
Sep 4, 2023

Conversation

a-sr
Copy link
Member

@a-sr a-sr commented Aug 17, 2023

  • Adapted to use Maven artifacts of KLighD
  • Moved LS code that is no longer a plugin
  • Bumped Eclipse versions to latest release

TODO => @NiklasRentzCAU or @soerendomroes :

  • Test language server in Eclipse
  • Test language server artifact in VS Code extension
  • Check other development streams (Elk, Klighd)
    • Adopt new target platform

@a-sr a-sr marked this pull request as ready for review August 21, 2023 16:44
@soerendomroes
Copy link
Member

I tested compilation and simulation of Abro as well as several synthesis options for the language server artifact in the language server extension.

@soerendomroes
Copy link
Member

I tested the other two development streams. Both could start an LS that could connect via socket and simulate a model.

Copy link
Member

@NiklasRentzCAU NiklasRentzCAU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some minor things, LGTM otherwise. Works together with KLighD as well in the new setup and seems ready to be merged.

@a-sr a-sr merged commit badcc12 into master Sep 4, 2023
1 check passed
@a-sr a-sr deleted the als/ls-maven branch September 4, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants