Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1240 waitForView on label in tableview not working #1241

Merged
merged 4 commits into from
Nov 1, 2021
Merged

Fix #1240 waitForView on label in tableview not working #1241

merged 4 commits into from
Nov 1, 2021

Conversation

dostrander
Copy link
Contributor

UIAccessibilityElementMockView does not respond to the selector view anymore, which causes the tableview to be returned when looking for a subview in the hierarchy.

This checks the class name to see if it's a UIAccessibilityElementMockView then will get the view via valueForKey:

Fixes #1240

This was referenced Oct 27, 2021
Closed
Closed
justinseanmartin
justinseanmartin approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@justinseanmartin justinseanmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add an Xcode 13 CI config to verify the fix?

harleyjcooper
harleyjcooper approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@harleyjcooper harleyjcooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@bcriscuolo
Copy link

Hey there @dostrander I wanted to report to you that I've confirmed this in our rather large KIF implementation by applying the changes locally. Looking great so far, and will pull in the release as soon as you have it up. Thanks!

Brian Criscuolo - Salesforce Field Service

@dostrander dostrander force-pushed the 1240-waitForView branch 4 times, most recently from d97cf77 to d3739b7 Compare October 27, 2021 21:15
@dostrander dostrander merged commit 0999601 into master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinseanmartin justinseanmartin justinseanmartin approved these changes

@harleyjcooper harleyjcooper harleyjcooper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Xcode 13 - waitForView(withAccessibilityIdentifier) issue
4 participants
@dostrander @bcriscuolo @justinseanmartin @harleyjcooper