Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider an animation:clone() function #1

Closed
Kadoba opened this issue Jun 4, 2012 · 2 comments
Closed

Consider an animation:clone() function #1

Kadoba opened this issue Jun 4, 2012 · 2 comments

Comments

@Kadoba
Copy link

Kadoba commented Jun 4, 2012

Consider creating a clone function for animations. It would be nice to create animation prototypes and then clone from them.

@kikito
Copy link
Owner

kikito commented Jun 4, 2012

Mmmmm. I don't know why, but I find myself hesitating to add that feature. Trouble is, I can't really say why. It's just that my arachnid sense is tingling.

On the other hand, it makes total sense. Let me think about this for a while.

@kikito kikito closed this as completed in 5fa9adb Jun 6, 2012
@kikito
Copy link
Owner

kikito commented Jun 6, 2012

The thing that was "nagging me" was my "that is not proper object orientation!" alarm.

But hey, Lua is not object oriented by default. A clone() method seems very reasonable in a prototype-based language.

Besides, adding the method involved 3 lines of code. I might as well give my users some pleasure.

In any case, this is done. I've released v1.1.0 with your two suggestions. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants