TypeScript definition fixes #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- onConfirm / onCancel replaced with `confirmCallback` / `cancelCallback` - The main Buefy `install` function now adheres to the Vue3 Plugin_2 type
kikuomax
added a commit
that referenced
this pull request
Sep 1, 2023
* chore: upgrade jest-serializer-vue - Bumps jest-serializer-vue from 0.3.0 to 3.1.0 because version 0.3.0 shall not work with V2 of `@vue/test-utils`. See: eddyerburgh/jest-serializer-vue#56 * chore: install jest-dom - Installs `@testing-library/jest-dom` to enable `toBeEmptyDOMElement` assertion. * test(lib): polyfill window.crypto - Polyfills `window.crypto` in the test environment to provide `window.crypto.getRandomValues`. It is defined in a newly introduced file `jest-setup.js` that runs before every test case. issue ntohq#1 (comment) * chore(lib): uninstall sinon - Uninstalls `sinon` because no tests directly depend on it. issue ntohq#1 * chore: resync package name and version - Name → @ntohq/buefy-next - Version → 0.1.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm attempting to convert a project using Buefy to Vue3 using this fork, so far very successfully (thanks!). It's also using TypeScript, and I realized those definitions have probably not been touched. Here's a few basic ones, which at least make sure
app.use(Buefy)isn't an error, and programmatic dialogs don't suggestonConfirm/onCancelanymore. I want to look at the other definitions for programmatic access later.