fix: hardcoded sprite import #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the generated component would only be able to import the `href` if the outputPath ended in `sprite.tsx`, for example: ``` npx rmx-cli svg-sprite assets/icons app/components/icons/sprite.tsx ``` With this change, the sprite href import matches the filename correctly for outputPath with and without the filename declared i.e ``` npx rmx-cli svg-sprite assets/icons app/components/icons/foo.tsx npx rmx-cli svg-sprite assets/icons app/components/icons/ ```
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the generated component would only be able to import the
hrefif the outputPath ended insprite.tsx, for example:With this change, the sprite href import matches the filename correctly for outputPath with and without the filename declared i.e.