Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple crates #76

Merged
merged 7 commits into from
Mar 1, 2016
Merged

Multiple crates #76

merged 7 commits into from
Mar 1, 2016

Conversation

killercup
Copy link
Owner

I've been talking about this with @jplatte on IRC for a while.

We still need to add some tests for this. E.g.:

  • adding zero crates fails (already exists)
  • adding ≥2 crates works and fetches the latest version numbers from crates.io
  • adding ≥2 crates with --dev and --build works
  • adding ≥2 crates with --optional
  • adding ≥2 crates with --optional but also with --dev(or --build) fails
  • adding ≥2 crates with explicit versions (e.g. cargo add regex@0.1.42 nom@1.0.0) works
  • adding ≥2 crates with mixed explicit versions (e.g. cargo add regex nom@1.0.0) works

Concerns #59

Jonas Platte and others added 3 commits February 13, 2016 21:09
@killercup
Copy link
Owner Author

I added a few requirements for tests. I'd be happy to write them later, but you can also give it a try if you want to and have more time, @jplatte :)

@jplatte
Copy link
Collaborator

jplatte commented Feb 29, 2016

Yeah, I should have time this evening and will give it a try then.

@killercup
Copy link
Owner Author

@jplatte I added one more test (fails_to_add_multiple_optional_dev_dependency) and it appears we now have tests for all cases. Did I miss something?

@jplatte
Copy link
Collaborator

jplatte commented Mar 1, 2016

@killercup Yeah, you actually didn't properly test for the dependencies not being present before trying to add them, I fixed that in the first commit. I also pushed a tiny name refactoring commit, because the tests for adding a single dependency were named inconsistently (_dependency for the ones that should fail, _dependencies for the ones that should work).

@killercup
Copy link
Owner Author

Good catches! I'm going to merge this. We can fix/add stuff later, of course.

@homu r+

@homu
Copy link
Contributor

homu commented Mar 1, 2016

📌 Commit e30cd51 has been approved by killercup

@homu
Copy link
Contributor

homu commented Mar 1, 2016

⚡ Test exempted - status

@homu homu merged commit e30cd51 into master Mar 1, 2016
homu added a commit that referenced this pull request Mar 1, 2016
Multiple crates

I've been talking about this with @jplatte on IRC for a while.

We still need to add some tests for this. E.g.:

- [x] adding zero crates fails (_already exists_)
- [x] adding ≥2 crates works and fetches the latest version numbers from crates.io
- [x] adding ≥2 crates with `--dev` and `--build` works
- [x] adding ≥2 crates with `--optional`
- [x] adding ≥2 crates with `--optional` but also with `--dev`(or `--build`) fails
- [x] adding ≥2 crates with explicit versions (e.g. `cargo add regex@0.1.42 nom@1.0.0`) works
- [x] adding ≥2 crates with mixed explicit versions (e.g. `cargo add regex nom@1.0.0`) works

Concerns #59
@killercup killercup deleted the feature/59-multiple-crates branch January 4, 2017 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants