-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple crates #76
Multiple crates #76
Conversation
There are no actual tests for the new cases, though!
WIP, no tests for this
I added a few requirements for tests. I'd be happy to write them later, but you can also give it a try if you want to and have more time, @jplatte :) |
Yeah, I should have time this evening and will give it a try then. |
9d10cc7
to
e2637c8
Compare
@jplatte I added one more test ( |
@killercup Yeah, you actually didn't properly test for the dependencies not being present before trying to add them, I fixed that in the first commit. I also pushed a tiny name refactoring commit, because the tests for adding a single dependency were named inconsistently ( |
Good catches! I'm going to merge this. We can fix/add stuff later, of course. @homu r+ |
📌 Commit e30cd51 has been approved by |
⚡ Test exempted - status |
Multiple crates I've been talking about this with @jplatte on IRC for a while. We still need to add some tests for this. E.g.: - [x] adding zero crates fails (_already exists_) - [x] adding ≥2 crates works and fetches the latest version numbers from crates.io - [x] adding ≥2 crates with `--dev` and `--build` works - [x] adding ≥2 crates with `--optional` - [x] adding ≥2 crates with `--optional` but also with `--dev`(or `--build`) fails - [x] adding ≥2 crates with explicit versions (e.g. `cargo add regex@0.1.42 nom@1.0.0`) works - [x] adding ≥2 crates with mixed explicit versions (e.g. `cargo add regex nom@1.0.0`) works Concerns #59
I've been talking about this with @jplatte on IRC for a while.
We still need to add some tests for this. E.g.:
--dev
and--build
works--optional
--optional
but also with--dev
(or--build
) failscargo add regex@0.1.42 nom@1.0.0
) workscargo add regex nom@1.0.0
) worksConcerns #59