Add the correct crate name (as in crates.io) to toml and notify user #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killercup
requested changes
Jan 1, 2017
| .ok_or(FetchVersionError::CratesIo(CratesIoError::NotFound))); | ||
|
|
||
| if name != crate_name { | ||
| println!("WARN: Added {} instead of {}", name, crate_name); |
There was a problem hiding this comment.
Good reminder to add an actual logging facility some time soon (but not in this PR) :)
| let v = format!("{prefix}{version}", | ||
| prefix = self.get_upgrade_prefix().unwrap_or(""), | ||
| version = try!(get_latest_version(&self.arg_crate))); | ||
| dependency.set_version(&v) | ||
| version = dep.version().unwrap_or_else(|| unreachable!())); |
There was a problem hiding this comment.
Can you add a comment why you are sure this is actually always present and unreachable is fine here?
| use std::path::Path; | ||
| use rustc_serialize::json; | ||
| use rustc_serialize::json::{BuilderError, Json}; | ||
|
|
There was a problem hiding this comment.
Please remove leading empty line
|
Done. |
killercup
approved these changes
Jan 2, 2017
Merged
homu
added a commit
that referenced
this pull request
Jan 3, 2017
…rcup New year, new bugfixes This is a rollup of #98 (which replaces #78), #99, and #100. @sebasgarcep and @sinkuu, thank you for your PRs! Do you have time to review this? I've add a few tests and changed to code slightly, before running Rustfmt and Clippy. Just to make sure Github gets all the references: Fixes #52 Fixes #88 Fixes #92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resurrecting #78