Improve fetch algorithm. Ignore yanked when no version is specified. … #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Request only versions from server to save bandwith.
killercup
reviewed
Jan 2, 2017
There was a problem hiding this comment.
Thanks! I would like to see the code without a for-loop, and add some tests. But don't worry, I'll do that.
I saw you opened #99 as well (thanks for that as well!), so I'll quickly rewrite the loop, add some tests, and put that into a new PR (for CI). Your commits will stay intact and once this new PR is merged this one and #99 will be set to "merged" automatically.
| } | ||
| } | ||
| return None; | ||
| }) |
There was a problem hiding this comment.
I think this can be written more succinctly with .iter().filter() (or find)
killercup
added a commit
that referenced
this pull request
Jan 2, 2017
killercup
added a commit
that referenced
this pull request
Jan 2, 2017
Merged
homu
added a commit
that referenced
this pull request
Jan 3, 2017
…rcup New year, new bugfixes This is a rollup of #98 (which replaces #78), #99, and #100. @sebasgarcep and @sinkuu, thank you for your PRs! Do you have time to review this? I've add a few tests and changed to code slightly, before running Rustfmt and Clippy. Just to make sure Github gets all the references: Fixes #52 Fixes #88 Fixes #92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes all tests. Solves #88.