Add tests for removing existing dependencies #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds `remove_existing_dependency` and `remove_existing_dependency_from_specific_section` to test removing dependencies from arbitrary, build, and dev sections. This also modifies the Cargo.toml fixture to add a build section to test removing from this section.
|
Once this gets merged, it should close #28. |
|
Awesome, thanks! @homu r+ |
|
📌 Commit 7cf1ad9 has been approved by |
homu
added a commit
that referenced
this pull request
Oct 23, 2015
Add tests for removing existing dependencies This adds `remove_existing_dependency` and `remove_existing_dependency_from_specific_section` to test removing dependencies from arbitrary, build, and dev sections. This also modifies the Cargo.toml fixture to add a build section to test removing from this section.
|
☀️ Test successful - status |
Merged
homu
added a commit
that referenced
this pull request
Jan 3, 2017
…rcup New year, new bugfixes This is a rollup of #98 (which replaces #78), #99, and #100. @sebasgarcep and @sinkuu, thank you for your PRs! Do you have time to review this? I've add a few tests and changed to code slightly, before running Rustfmt and Clippy. Just to make sure Github gets all the references: Fixes #52 Fixes #88 Fixes #92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
remove_existing_dependencyandremove_existing_dependency_from_specific_sectionto test removingdependencies from arbitrary, build, and dev sections.
This also modifies the Cargo.toml fixture to add a build section to test
removing from this section.