Return error if name in crates.io is different

[caulagi]

As described in #51, I have added a check to validate the crate_name is the same as the one on crates.io or return an error.

$ ./target/debug/cargo-add add error-def
Command failed due to unhandled error: crates.io Error: NotFound
$
$ ./target/debug/cargo-add add error_def
$

I have added a couple of tests as well, but they actually hit crates.io endpoint.

[killercup]

Am I understanding correctly that the crates.io API actually gives us the
'correct' (i.e. normalized) name?

Would it then not make sense to just insert the normalized name (and maybe
tell the user the new name in a log message)?

Pradip Caulagi notifications@github.com schrieb am Fr., 4. März 2016 um
11:17:

As described in #51 #51,
I have added a check to validate the crate_name is the same as the one on
crates.io or return an error.

$ ./target/debug/cargo-add add error-def
Command failed due to unhandled error: crates.io Error: NotFound
$
$ ./target/debug/cargo-add add error_def
$

I have added a couple of tests as well, but they actually hit crates.io

endpoint.

You can view, comment on, or merge this pull request online at:

#78
Commit Summary

• 🐛 Return error if name in crates.io is different from the name
  that is

File Changes

• M src/bin/add/fetch_version.rs
  https://github.com/killercup/cargo-edit/pull/78/files#diff-0 (33)

Patch Links:

• https://github.com/killercup/cargo-edit/pull/78.patch
• https://github.com/killercup/cargo-edit/pull/78.diff

—
Reply to this email directly or view it on GitHub
#78.

[caulagi]

Yes, that is my understanding as well, that crates.io gives the normalised name only for the case when there is a mismatch between underscores and hyphens. In other cases, where the crate name is mis-spelled/not-matching, we get "not found". I asked a question here - rust-lang/crates.io#283 - as I don't know if this is something that can be relied on.

[homu]

☔ The latest upstream changes (presumably #83) made this pull request unmergeable. Please resolve the merge conflicts.

[sinkuu]

I'm writing an editor extension to run cargo add for extern crateed missing dependencies, so I prefer correct name is used instead.

[killercup]

Superseded by #101