-
Notifications
You must be signed in to change notification settings - Fork 56
Latest trpl, trpl 2nd edition and rustonomicon sources. Dockerized all the things. #52
base: master
Are you sure you want to change the base?
Conversation
Each document directory now contains a meta.yml by default (Optionally elsewhere) The "prefix" argument becomes the same as the document directory name by default (Optionally something else) Removed unused imports.
Added files of TRPL 2nd Edition. Adjusted Programm to behave accordingly. pandoc version >= 2 is required
Updated release date Added make option for trpl 2nd edition. * dockerize: Fixed Makefile Dockerized the application. Runnable via make
Wow, just looking at the commits this looks very impressive. You seem to have spend a lot of time on this! Can you publish the PDF files that this produces? (I currently don't have time to maintain this further. If what this produces is any good, I'd gladly nominate you the new maintainer of the project.) |
Reverted code for chapters and trpl2 SUMMARY accordingly.
I ran into an error building the pdf for trpl2, but otherwise this worked great for me, and I'm now happily reading the second edition on my ereader. Let me know if it would be helpful for me to send the build artifacts in some way. (Also - shouldn't these files be supplied by the project itself? I guess they don't want to stop on the toes of the publisher.) |
Thanks for the offer @killercup . But I'd like not to keep this in my hands as my rust skills are somewhat rusty. And I hope the official mdBook solution gets a proper EPUB option. I've send you the PDF files you asked for. As @ohbadiah mentioned the creation of the PDFs for the trpl second edition fails. It looks like there is a parsing error in "ch14-04-installing-binaries.md". I was not able to find the actual problem resulting in that error. |
@abcdev , thanks a lot for that! Would it be possible to post those PDF files somewhere so that other people also can get them before issues get resolved? I'd love to see those PDFs! |
Here are the errors I'm getting with generating PDFs:
I checked and apparently that comes from the file
and apparently it isn't handled correctly when generating tex file:
I'm not sure what's the real issue, but I just worked it around for me by replacing those backslashes with
But still, the PDF looks quite readable. Thanks again! |
For the future readers who just want to get some PDFs, let me attach those: trpl2-2018-06-02.a4.pdf |
Hey guys, I know this PR is quite old, but wondering if it would be simpler to simply fetch the latest rustbook + nomicon from the website instead of storing it in the repo. It will be part of the running process, i.e That way it will always be up to date. What do you guys think? |
Would be great to have it on the website, I found this by prodding through github issues, it's a shame.. |
In order to work with latest rustonomicon sources and trpl 2nd edition, I altered some things in the project. Some changes are cosmetic others are necessary (like working with a newer pandoc version).
Dockerized the application for easy access and execution.