Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a extension pop-up design #20

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

MatiasIslaA
Copy link
Contributor

I've added an extension pop-up design consistent with the site style.

@killergerbah killergerbah merged commit 703084e into killergerbah:main Apr 28, 2021
@killergerbah
Copy link
Owner

Thank you. If you are up for the challenge and have the time, I wonder if you would be able to make the style closer to the Material UI styles? For example: https://material-ui.com/components/checkboxes/

@MatiasIslaA
Copy link
Contributor Author

Sure! I'll be busy until Wednesday though. I'll try to send a pull request on Friday.
By the way, would it be ok if I try to help with the other issues you've added? Since I'm a beginner at coding this is a great opportunity for learning and I would love the challenge of contributing to this project.

@killergerbah
Copy link
Owner

Sure no problem, feel free to work on whichever issues you please. Thanks for contributing!

@MatiasIslaA
Copy link
Contributor Author

Thank you. If you are up for the challenge and have the time, I wonder if you would be able to make the style closer to the Material UI styles? For example: https://material-ui.com/components/checkboxes/

@killergerbah I suddenly got a little bit of free time so I tried it right away... something like this or would you prefer softer colors? The transition when you click lost quality in the gif but you can get a general idea of how it looks. I tried to mimic the big circle that forms when you hover like the one of Material UI but it looked excesive due to the small size of the box so I made it a little more discrete. If it's okay, tell me and I'll send the pull request.

Alt Text

@killergerbah
Copy link
Owner

@MatiasIslaA Thanks! This looks really good. My only thought:

  • Can the text next to the each checkbox be vertically aligned with the middle of the checkbox?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants