Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find tix files for non-Main modules #5

Merged
merged 1 commit into from
Apr 5, 2014

Conversation

maoe
Copy link
Contributor

@maoe maoe commented Apr 5, 2014

I found a case where hpc-coveralls couldn't find a tix file: https://travis-ci.org/maoe/influxdb-haskell/jobs/22322723#L985

HPC sometimes puts a package ID prefix. In my case, the tix file for test-suite is something like:

Tix [ TixModule "influxdb-0.0.0/Database.InfluxDB.Types" 2843817 ...

and dist/hpc directory looks like:

dist/hpc/mix/influxdb-0.0.0/influxdb-0.0.0/Database.InfluxDB.Decode.mix
dist/hpc/mix/influxdb-0.0.0/influxdb-0.0.0/Database.InfluxDB.Encode.mix
dist/hpc/mix/influxdb-0.0.0/influxdb-0.0.0/Database.InfluxDB.Http.mix
dist/hpc/mix/influxdb-0.0.0/influxdb-0.0.0/Database.InfluxDB.Lens.mix
dist/hpc/mix/influxdb-0.0.0/influxdb-0.0.0/Database.InfluxDB.mix
dist/hpc/mix/influxdb-0.0.0/influxdb-0.0.0/Database.InfluxDB.Stream.mix
dist/hpc/mix/influxdb-0.0.0/influxdb-0.0.0/Database.InfluxDB.Types.Internal.mix
dist/hpc/mix/influxdb-0.0.0/influxdb-0.0.0/Database.InfluxDB.Types.mix
dist/hpc/mix/test-suite/Main.mix
dist/hpc/tix/test-suite/test-suite.tix

I've tested the patch locally with 7.6.3 and 7.4.2, but haven't actually tried it on Travis-CI and Coveralls. It would be appreciated if you also could test it.

@killy971
Copy link
Owner

killy971 commented Apr 5, 2014

Thank you very much for your patch.
I'm going to test how it goes with Coveralls

@killy971
Copy link
Owner

killy971 commented Apr 5, 2014

I've just tested your change, and it works fine.
I'm going to merge it, and it will be included in v0.2.0 release (I don't know yet when it will be released) with other improvements.

If you ever want to use hpc-coveralls HEAD version from now, you can replace the following before_install instruction in your .travis.yml configuration file:

  - cabal install hpc-coveralls

by:

  - git clone https://github.com/guillaume-nargeot/hpc-coveralls.git
  - cd hpc-coveralls
  - cabal install
  - cd ..

It is not guaranteed to be stable, but I'm doing my best to keep it stable.

killy971 added a commit that referenced this pull request Apr 5, 2014
Find tix fields for non-Main modules
@killy971 killy971 merged commit 69f0bb0 into killy971:master Apr 5, 2014
@maoe maoe changed the title Find tix fiels for non-Main modules Find tix files for non-Main modules Apr 5, 2014
@maoe maoe deleted the mix-not-found branch April 5, 2014 13:00
@maoe
Copy link
Contributor Author

maoe commented Apr 5, 2014

Thanks!

@killy971
Copy link
Owner

killy971 commented Apr 5, 2014

I've released your change to Hackage as version 0.1.2, after a few hiccups with branching/merging/tagging (I'm quite new to git workflow...).
You can now use it again with the following command in your travis config:
- cabal install hpc-coveralls
or
- cabal install hpc-coveralls-0.1.2

Please tell me if you still have problems

@maoe
Copy link
Contributor Author

maoe commented Apr 6, 2014

@killy971 killy971 added the bug label Apr 7, 2014
@killy971 killy971 added this to the v2.0.0 milestone Apr 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants