-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add #[must_use] to generate function #41
Conversation
The clippy lint https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate suggest that this function should have a must use flag - it does seem sensible to me.
Hey, this sounds reasonable. I need to check, how it would play with the scenario, which I personally use a lot: a crate which serves only one target - to collect resources and export single function, which would be later used in another crate. If it goes well, I think it is good idea to add it, but probably I would just add it without merging this PR, because I already reworked this part of code. |
No problem... if you choose to not make it |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Do you still need anything or should I close the PR? |
I created a separate issue #44 to track this for |
Ok thanks no worries |
The clippy lint https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate suggest that this function should have a must use flag - it does seem sensible to me. - but please verify this does not break anything.