Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic favicon #4038

Merged
merged 4 commits into from
May 21, 2023
Merged

Dynamic favicon #4038

merged 4 commits into from
May 21, 2023

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented May 20, 2023

Description

Added dynamic favicon that changes, when an entry is running
Bildschirmfoto 2023-05-21 um 14 31 43
Bildschirmfoto 2023-05-21 um 14 31 53

This is especially helpful for pinned tabs:
Bildschirmfoto 2023-05-21 um 14 32 24
Bildschirmfoto 2023-05-21 um 14 32 36

Needs the "Update browser title" user-preference to be activated.
Does work in Chrome, Brave, Firefox.
Safari always had terrible favicon support and it doesn't work there.

Fixes #3057

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai (see license)

@kevinpapst kevinpapst added the release a new minor version - PR will not be included in release notes label May 20, 2023
@kevinpapst kevinpapst added this to the 2.1 - Stabilizing milestone May 20, 2023
@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Merging #4038 (45e5045) into main (2664d61) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4038   +/-   ##
=========================================
  Coverage     89.29%   89.29%           
  Complexity     8442     8442           
=========================================
  Files           765      765           
  Lines         28408    28408           
=========================================
  Hits          25367    25367           
  Misses         3041     3041           

see 2 files with indirect coverage changes

@kevinpapst kevinpapst changed the title Release 2.0.23 Dynamic favicon May 21, 2023
@kevinpapst kevinpapst added feature request and removed release a new minor version - PR will not be included in release notes labels May 21, 2023
@kevinpapst kevinpapst marked this pull request as ready for review May 21, 2023 13:40
@kevinpapst kevinpapst merged commit 7ab0a8c into main May 21, 2023
@kevinpapst kevinpapst deleted the release-2.0.23 branch May 21, 2023 13:40
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change favicon while tracking
1 participant