This repository has been archived by the owner on Dec 17, 2022. It is now read-only.
doctrine 3 compliant #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doctrine 3 compliant
|
Thanks @manzolo ! I will have to check all my apps, currently none of them is using Doctrine 3. |
|
Sorry, but I'm not sure it's BC safe ... EntityManagerInterface is also present in symfony 3.3 https://symfony.com/doc/3.3/doctrine.html#persisting-objects-to-the-database, I would feel comfortable, but take your time to verify that everything works, in the meantime I fork :-) Thanks to you for the excellent work |
|
This fixed an issue in one app I am working on. Thanks for the PR! I am not entirely sure about the BC compatibility, so I first merge and test some more before creating a new release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can it be useful to fix https://github.com/doctrine/DoctrineBundle/blob/master/UPGRADE-2.0.md#service-aliases ?