Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations update from Hosted Weblate #203

Merged
merged 1 commit into from
Jan 22, 2023

Conversation

weblate
Copy link
Contributor

@weblate weblate commented Jan 22, 2023

Translations update from Hosted Weblate for Kimai - Time tracking/www.kimai.org.

Current translation status:

Weblate translation status

@weblate weblate force-pushed the weblate-kimai-website branch 2 times, most recently from 021fdc0 to f99274a Compare January 22, 2023 19:58
@kevinpapst
Copy link
Member

@yarons thank you for your continuous support with translations ❤️

But I need to ask for a favor. I worked a lot this weekend to simplify translation of the website, without me having to fiddle in thousand files. That's why there popped up so many new translation keys for the www.kimai.org component.

Now I activated Chinese first, because it was 100% translated (at least before I added all the new keys 😁). Next I wanted to enable Hebrew, but on the website I haven't had RTL support. So I added that tonight. And I added the Hebrew pages, but did not really activate them, because I wanted you to double check it before adding them to the language dropdown menu.

So here finally comes the question:
Can you please check if everything looks correct at https://www.kimai.org/he/ and let me know which issues you see.

Currently translated at 68.2% (321 of 470 strings)

Translated using Weblate (English)

Currently translated at 100.0% (470 of 470 strings)

Translated using Weblate (German)

Currently translated at 60.6% (285 of 470 strings)

Translated using Weblate (English)

Currently translated at 100.0% (470 of 470 strings)

Translated using Weblate (German)

Currently translated at 53.8% (253 of 470 strings)

Translated using Weblate (Hebrew)

Currently translated at 44.6% (210 of 470 strings)

Translated using Weblate (Croatian)

Currently translated at 94.0% (442 of 470 strings)

Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Kevin Papst <kevin@kevinpapst.de>
Co-authored-by: Milo Ivir <mail@milotype.de>
Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/kimai/website/de/
Translate-URL: https://hosted.weblate.org/projects/kimai/website/en/
Translate-URL: https://hosted.weblate.org/projects/kimai/website/he/
Translate-URL: https://hosted.weblate.org/projects/kimai/website/hr/
Translation: Kimai - Time tracking/www.kimai.org
@kevinpapst kevinpapst merged commit e6acaa0 into kimai:main Jan 22, 2023
@yarons
Copy link
Contributor

yarons commented Jan 24, 2023

There are some small glitches but overall it looks great.
At the bottom it says: Made by GitHub @ Kevin Pepst 😆 (We can add an RLM character next to the @ symbol :)

@kevinpapst
Copy link
Member

Hahaha, I didn't notice that one 😁 thanks for checking @yarons

I tried to add a <span dir="ltr"> around the links text and I tried to remove all whitespace, but it still looks wrong:

Bildschirm­foto 2023-01-24 um 13 53 51

What is a RLM symbol? How do I do that?
Could you do it? https://github.com/kimai/www.kimai.org/blob/main/_includes/footer.html#L16

@kevinpapst kevinpapst mentioned this pull request Jan 24, 2023
@kevinpapst
Copy link
Member

I added a workaround for the footer. If you have a better idea, I'd like to hear it. But it seems to work now.

One more question: the pages which are not yet translated, like "About Kimai" - is it better to have them like this:
Bildschirm­foto 2023-01-24 um 15 54 15

Or ist it better to reset via dir="ltr" and display them in the "original direction":
Bildschirm­foto 2023-01-24 um 15 54 23

@yarons
Copy link
Contributor

yarons commented Jan 25, 2023

TL;DR - The second option for now.
It just need some tweaking to work properly, I'll try to come up with something.

Apparently there's a right float left originated from the float-sm-end CSS class, it is possible to override certain CSS statements when using RTL.

image
The text will be aligned according to the RTL statement once I'll finish translating this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants