Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make check-local must verify trailing whitespaces in docs/API.md #44

Closed
danielhb opened this issue Nov 23, 2015 · 3 comments
Closed

make check-local must verify trailing whitespaces in docs/API.md #44

danielhb opened this issue Nov 23, 2015 · 3 comments
Assignees
@danielhb
Labels
bug

Comments

@danielhb
Copy link
Contributor

Because seeing the whitespaces appearing after applying a patch is killing my vibe.
@danielhb danielhb added the bug label Nov 23, 2015
@pvital
Copy link
Member

pvital commented Nov 23, 2015

"...killing my vibe."??!!
LOL

@danielhb danielhb self-assigned this Nov 23, 2015
@danielhb
Copy link
Contributor Author

Patch was sent to ML. Hopefully my vibe will survive until it's fixed!

danielhb added a commit that referenced this issue Nov 25, 2015
@danielhb
Github #44: make check-local improvements
9d96ff0 
This patch adds the following verifications in the 'check-local'
make target:

- trailing whitespace and new blank lines errors

- unused i18n messages

Signed-off-by: Daniel Henrique Barboza <dhbarboza82@gmail.com>
@danielhb
Copy link
Contributor Author

Fix is available upstream! Rejoice!

@danielhb danielhb mentioned this issue Dec 15, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielhb danielhb

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pvital @danielhb