Add automatic tags. #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConstructedTypes now have a method to autotag their components. This will wrap all components in a TaggedType with incrementing tag number, but only if no components are already tagged (as per the ASN.1 specification). After generating the module(s) this method is called on all ConstructedTypes in the tree if the module's tag default is AUTOMATIC. Ignore ExtensionMarkers when autotagging. Resolves #20.
kimgr
added a commit
that referenced
this pull request
Dec 22, 2015
Add support for AUTOMATIC TAGS. Patch by James Ward, thanks!
|
Thanks! Sorry this took so long. I'll make a few local refactors, I had some ideas I think will simplify the TaggedType construction. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConstructedTypes now have a method to autotag their components.
This will wrap all components in a TaggedType with incrementing
tag number, but only if no components are already tagged (as per
the ASN.1 specification).
After generating the module(s) this method is called on all
ConstructedTypes in the tree if the module's tag default is
AUTOMATIC.
Ignore ExtensionMarkers when autotagging.
Resolves #20.