Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic tags. #29

Merged
merged 1 commit into from
Dec 22, 2015
Merged

Add automatic tags. #29

merged 1 commit into from
Dec 22, 2015

Conversation

james-ward
Copy link
Contributor

ConstructedTypes now have a method to autotag their components.
This will wrap all components in a TaggedType with incrementing
tag number, but only if no components are already tagged (as per
the ASN.1 specification).

After generating the module(s) this method is called on all
ConstructedTypes in the tree if the module's tag default is
AUTOMATIC.

Ignore ExtensionMarkers when autotagging.

Resolves #20.

ConstructedTypes now have a method to autotag their components.
This will wrap all components in a TaggedType with incrementing
tag number, but only if no components are already tagged (as per
the ASN.1 specification).

After generating the module(s) this method is called on all
ConstructedTypes in the tree if the module's tag default is
AUTOMATIC.

Ignore ExtensionMarkers when autotagging.

Resolves #20.
kimgr added a commit that referenced this pull request Dec 22, 2015
Add support for AUTOMATIC TAGS.

Patch by James Ward, thanks!
@kimgr kimgr merged commit da6539d into kimgr:master Dec 22, 2015
@kimgr
Copy link
Owner

kimgr commented Dec 22, 2015

Thanks! Sorry this took so long.

I'll make a few local refactors, I had some ideas I think will simplify the TaggedType construction.

@kimgr kimgr mentioned this pull request Dec 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants