Additional parsing functionality #5
Conversation
|
Thank you! I won't be able to look at this for a while, but it's much appreciated. In the meantime, any chance you could add tests for the basic constructs you've added? Under testdata/ there are example ASN.1 definitions for isolated constructs (IA5String should go in string_types.asn, for example) and a public/ directory where DSRC_R36_Source.ASN would be welcome. Thanks! |
Test for extension marker with enumerated type.
Allow hex or binary references for assignment. Go back through the module's dependency graph to determine the root type and parse the string accordingly.
Default to stdin for input if no argument provided.
Add import statements if generating more than one module. Test for multiple modules. No cross referencing.
Test for IA5String.
…raint. Process size constraints for types. Only allow constraints for those types defined in the specs.
…ions definitions to public test data. Downloaded from: http://www.sae.org/standardsdev/dsrc/DSRC_R36_Source.ASN
|
I've looked over most of the commits now, and I just want to say thanks again! And thanks for the tests, I didn't notice them the first time around... :o) I think some of the solutions have ended up in the wrong place (e.g. sema should not care about Python names, that belongs in codegen), but most of this looks immediately useful. I don't think I want to merge everything as-is, but I'd be happy to adjust it to my preference if that's OK with you? |
|
Kim, Cheers, On 16/12/13 07:01, Kim Gräsman wrote:
James Ward |
…ed to a range. Bit string now optionally has a succeeding list of named bits. Added possiblility to use identifiers in ASN.1 with hypens by transposing each occurence of this character to a Z.
|
I think I've finally fixed everything this PR covers, except for the multi-module codegen. That's an interesting problem in its own right, but I think I'll defer it for now. It might make sense to build a more sophisticated codegen driver to handle it. So, a big thank-you for all your help with this! I'll close this, if you run into problems with my approach, please post new issues.
|
Correct version of code that can parse SAE J2735 as shown here:
http://www.sae.org/standardsdev/dsrc/DSRC_R36_Source.ASN