I18n improvements #254
Merged
I18n improvements #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Кошик" means trash can
Other favorites are named more briefly.
|
Someone is attempting to deploy a commit to a Personal Account owned by @kimlimjustin on Vercel. @kimlimjustin first needs to authorize it. |
kimlimjustin
requested changes
May 15, 2022
| <option value="mica" ${transparentEffect === 'mica' ? 'selected' : ''} ${!(platform === 'win32' && (await isWin11())) ? 'disabled' : '' | ||
| } ${disabledForWeb}>${mica_i18n}</option> | ||
| <option value="vibrancy" ${transparentEffect === 'vibrancy' ? 'selected' : ''} ${platform !== 'darwin' ? 'disabled' : '' | ||
| } ${disabledForWeb}>${vibrancy_i18n}</option> | ||
| <option value="none" ${transparentEffect === 'none' ? 'selected' : ''}>None</option> |
There was a problem hiding this comment.
I think you forgot to change this one too, could you please edit it? hehe
There was a problem hiding this comment.
Oh... yes!
It was in my local repo, but when I was cleaning stuff up for the PR it somehow got lost
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kimlimjustin
approved these changes
May 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There were some places in the interface, where text appeared to be not translated.
Changes
Localisation improvements. Added I18n to the places where text was hardcoded. Fixed a typo and improved couple of wordings. Translated all now-presented strings to the ukrainian language.