More gracefully make calls to Helper() #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of checking if the printer adheres to the testing.tt interface throughout, wrap any non-matching types in a utility with a NOOP Helper() implementation. Removes the unnecessary exposure of the provided Printer in the Asserter. In the strictest sense, this change isn't backwards compatible, in that Asserter no longer exposes a Printer field. If for some obscure reason this affects you, you can replace all calls to ja.Printer with the type that you passed in to New().
kinbiko
force-pushed
the
more-graceful-helper
branch
from
174e63b
to
9e0e454
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of checking if the printer adheres to the testing.tt interface
throughout, wrap any non-matching types in a utility with a NOOP
Helper() implementation.
Removes the unnecessary exposure of the provided Printer in the
Asserter.
In the strictest sense, this change isn't backwards compatible, in that
Asserter no longer exposes a Printer field.
If for some obscure reason this affects you, you can replace all calls
to ja.Printer with the type that you passed in to New().