Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLG output as Dolby Vision instead of HDR #615

Closed
edge261 opened this issue Nov 6, 2023 · 5 comments
Closed

HLG output as Dolby Vision instead of HDR #615

edge261 opened this issue Nov 6, 2023 · 5 comments

Comments

@edge261
Copy link

edge261 commented Nov 6, 2023

Describe the bug
As the title mentions.

To Reproduce
Steps to reproduce the behavior:

  1. Open a HLG stream

Expected behavior

It should output HDR instead of DV, because that's the treatment tvOS gives to HLG content... (different from the DV profile that uses HLG metadata)

Screenshots
https://github.com/kingslay/KSPlayer/assets/79731301/ec7cd1be-58ca-4743-98ae-e0f246487f20

Platform (please complete the following information):

  • Device: Apple TV 4K 2022
  • OS: tvOS 17.1

I can send a link to @kingslay of the kind of stream I mention, so he can see which parameters are needed to identify HLG.

@cdguy
Copy link

cdguy commented Nov 6, 2023

Describe the bug As the title mentions.

To Reproduce Steps to reproduce the behavior:

  1. Open a HLG stream

Expected behavior

It should output HDR instead of DV, because that's the treatment tvOS gives to HLG content... (different from the DV profile that uses HLG metadata)

Screenshots https://github.com/kingslay/KSPlayer/assets/79731301/ec7cd1be-58ca-4743-98ae-e0f246487f20

Platform (please complete the following information):

  • Device: Apple TV 4K 2022
  • OS: tvOS 17.1

I can send a link to @kingslay of the kind of stream I mention, so he can see which parameters are needed to identify HLG.

kingslay@icloud.com

also use this for the mail subjet: HLG output as Dolby Vision instead of HDR #615

@kingslay
Copy link
Owner

kingslay commented Nov 6, 2023

@edge261 你可以发一个一分钟的视频片段到github。这样我就可以测试了。目前视频是输出为dolbyVision,你是想要视频能够输出为HDR10吗?

@kingslay
Copy link
Owner

kingslay commented Nov 6, 2023

你可以简单的改下代码把var dynamicRange: DynamicRange { 这个函数返回值改成是.hdr10 进行测试,看下效果怎么样。看是否符合你的预期。

@edge261
Copy link
Author

edge261 commented Nov 6, 2023

你可以发一个一分钟的视频片段到github。这样我就可以测试了。目前视频是输出为dolbyVision,你是想要视频能够输出为HDR10吗?

@kingslay I sent a link to your email, please check. I don't know how to rip a clip so I prefer to send it...

And yes, it should output HDR10, since that's tvOS implementation.

https://developer.apple.com/forums/thread/666586

@edge261
Copy link
Author

edge261 commented Nov 6, 2023

你可以简单的改下代码把var dynamicRange: DynamicRange { 这个函数返回值改成是.hdr10 进行测试,看下效果怎么样。看是否符合你的预期。

Well, I believe it was done on one of the apps that uses KSplayer because I reported it directly and it fixed it.

However, it would be good to have that fixed for all the apps that uses this library so everyone gets the correct implementation instead of a per-app basis.

theonlymo pushed a commit to theonlymo/KSPlayer that referenced this issue Nov 16, 2023
* 'develop' of github.com:kingslay/KSPlayer:
  fix kingslay#616
  fix kingslay#615
  fix kingslay#617
  fix yuv422p10le colours kingslay#613
  fix kingslay#609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants