-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make matplotlib an optional dependency #287
Conversation
@gdmcbain can you make a quick review at this point? Comments on the overall structure would be appreciated and if you have any ideas or alternative implementation strategies. I'll continue with fixing rest of the examples after you agree this is the right way to go forwards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Should
skfem.visualize
itself be a package likeskfem.importers
withskfem.visualize.matplotlib
underneath it likeskfem.importers.meshio
? This might facilitate later adding other visualization backends like yt, pyvista, holoviews, …. Matplotlib is obviously primary for its ubiquity and good enough for most one- and two-dimensional work but it distorts three-dimensional views. -
Instead of the chains of
if (isinstance, ...)
wouldabc
orfunctools.singledispatch
be tidier?
Another thought for the further future: Thus far the visualization is based on the |
Removes the following features: - Drawing of piecewise constant functions for Mesh2D - Drawing of piecewise-linear DG functions for MeshTri These should be implemented using InteriorBasis.refinterp instead.
Fantastic suggestions, as usual. Here is a notebook I used during development. I'm going to implement also the possibility of drawing through InteriorBasis since I removed the plotting of piecewise-constant and DG functions and refinterp should be used instead. I was thinking syntax like this: plot(interior_basis, solution) and the call is the passed to |
Next I start fixing the examples. It might take a while. |
Starting by running the Makefile under docs/examples and fixing all errors. Later fixing the docs. |
Starting to be ready for review. Fixes #286 . |
Am I missing some examples? |
Starting work on #286 .