Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Use hashlink instead of linked-hash-map #8

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

GrayJack
Copy link
Contributor

linked-hash-map has been unmaintained for 2 years now and have some issues. And most crates are moving to hashlink which provides the same features.

@kinnison
Copy link
Owner

kinnison commented Apr 2, 2024

Hi,

Thank you for bringing this to my attention - can I ask please what your use/interest in my crate is? Also, changing this dependency will result in a major version bump so you can, I hope, understand if I need to take some time to decide if I want to take this on.

D.

@GrayJack GrayJack changed the title dips: Use hashlink instead of linked-hash-map deps: Use hashlink instead of linked-hash-map Apr 2, 2024
@GrayJack
Copy link
Contributor Author

GrayJack commented Apr 2, 2024

Hi!

Thank you for bringing this to my attention - can I ask please what your use/interest in my crate is?

I was the person who introduced this crate to rattler-build. So when I discovered this issue with linked-hash-map crate, I decided to investigate what is the spiritual successor of the crate and I discovered that most crates are migrating to hashlink

Also, changing this dependency will result in a major version bump so you can, I hope, understand if I need to take some time to decide if I want to take this on.

Not a problem to me! 😄

@kinnison
Copy link
Owner

kinnison commented Apr 3, 2024

Thank you for bringing this to my attention - can I ask please what your use/interest in my crate is?
I was the person who introduced this crate to rattler-build. So when I discovered this issue with linked-hash-map crate, I decided to investigate what is the spiritual successor of the crate and I discovered that most crates are migrating to hashlink

Aha, thanks, that's helpful for me to know, since rattler-build is one of the main consumers of marked-yaml which I was concerned about.

Also, changing this dependency will result in a major version bump so you can, I hope, understand if I need to take some time to decide if I want to take this on.
Not a problem to me! 😄

Coolbeans - I noticed that rattler have already upped to 0.4.0 which surprised me; so I'll definitely give this a go and if all looks well, I'll take it in for a 0.5.0 release soonish. I have a couple of quality-of-life things to do with the serde interface in here first though :D

Thank you again.

@kinnison
Copy link
Owner

kinnison commented Apr 3, 2024

It looks like you've missed all the doctests from your refactor - Could you add a commit to address those?

@kinnison kinnison merged commit e7bb268 into kinnison:main Apr 3, 2024
3 checks passed
@kinnison
Copy link
Owner

kinnison commented Apr 3, 2024

Thanks, this'll be in 0.5.0 assuming I get enough time tonight to work through what else I want to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants