eth: fix deadlock casued by multiple subscriptions/requests #457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Our default eth provider,
providerfren.os
, frequently hangs, requiring restart.Solution
Fix deadlock by minimizing the amount of time locks are acquired for. In particular move everything that communicates with a timeout outside of a lock.
Testing
To test I:
get_logs()
, by commenting outkinode/kinode/packages/kns_indexer/kns_indexer/src/lib.rs
Line 163 in fbf961e
Using that protocol, I get a deadlock immediately on master, whereas I have not witnessed a deadlock on this branch.
Docs Update
None
Notes
None