-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to drag out kint output to a pop up window for future reference and whatnot #46
Comments
I implemented this feature in my fork. Base64 was a bad idea because it breaks browser when there's a lot of debug data, so I implemented it this way: newWindow = window.open();
if(newWindow) {
newWindow.document.open();
newWindow.document.write(html);
newWindow.document.close();
} I fixed some compatibility issues with older PHP versions that don't support "static::" and "$var::" static calls. Also, I fixed the bug with Result: http://www.opengluco.com/demo/kint/demo.php Raveren, I'll make a pull request in 1.0.0-wip branch if you think this is OK. Could you just tell me which minifier script you're using for .js so I can minify it again before merge since there are some changes inside also. Thanks! |
Wow, dude, that is terrific! Sure, please do a pull request, these changes are totally awesome. I use a custom File Watchers Php storm plugin config, parameters of which are at the top of _kint.js (I know this sucks, I need to brush up contribution guidelines heavily). You can however just use the online compiler on advanced settings and then wrap the output inside |
Even the dumped object in your demo is awesomely crafted to showcase most of Kint features, that's just wonderful :) |
I was planing of making an interactive demo where you can switch themes and see the actual code behind, if you agree ;) |
* Fixes #46 (implemented "open in new window") * fixed the bug with `_stepIsInternal()` method which didn't detect call_user_func_array inside ```Kint``` class as internal when short functions were called * fixed some compatibility issues with older PHP versions that don't support "static::" and "$var::" static calls
That would be stellar! :) |
I've created a simple demo with theme switcher: http://www.opengluco.com/demo/kint/demo.php Any suggestions? |
Wow you even created a new theme :D Fucking A! I'm finishing up with my own batch of changes and will comment further tomorrow. |
My colleague did the theme, he'll make a pull request when it's done. |
It's lovely, I can't wait to use it myself! :) I'll be awaiting for the pull request and it would be great if you could put your demo in a new Thanks again! |
Thanks, fixed! |
Hey there, sorry to bump a closed thread but was wondering if this could be the default behavior for Kint.
Does it make sense? Btw is it possible to detach the already implemented pop out to a new window instead of a browser tab? Is there any config to allow this? |
Instead of
document.documentElement
use needed Kint nodes along with something along the lines ofdocument.querySelectorAll('script')[0].innerHTML
.The text was updated successfully, but these errors were encountered: