Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app to comply with GNOME HIG #35

Closed
4 tasks done
kinten108101 opened this issue Apr 16, 2023 · 2 comments · Fixed by #41
Closed
4 tasks done

Update app to comply with GNOME HIG #35

kinten108101 opened this issue Apr 16, 2023 · 2 comments · Fixed by #41
Assignees
Labels
Milestone

Comments

@kinten108101
Copy link
Owner

kinten108101 commented Apr 16, 2023

  • For accessibility, add options to move row up or down as an alternative to the drag handle. 1
  • Stack Page labels should be noun, not verb. 2
  • (CANCELLED) Scheme changes. Each stack view should be independent and cause no side effects to each other. 3
  • Remove ellipses in configure. 4

Acceptance criteria

  • All tasks done and application can run.

Footnotes

  1. https://developer.gnome.org/hig/patterns/containers/boxed-lists.html#editable-lists - Instead of showing a remove button at the end of each row, include a button menu, with items for “move up”, “move down,” and “remove” (menu items for move actions are required for accessibility purposes).

  2. https://developer.gnome.org/hig/patterns/nav/view-switchers.html#guidelines - Label views with header capitalization, and use nouns rather than verbs, for example Albums or Updates. Try to give view labels a similar length.

  3. https://developer.gnome.org/hig/patterns/nav/view-switchers.html#guidelines - When used for preferences, do not design views whose controls affect the controls in other views. Users are unlikely to discover such dependencies.

  4. https://developer.gnome.org/hig/guidelines/writing-style.html#ellipses - Do not add an ellipsis to labels such as Properties or Preferences. While these commands open windows that can incorporate further functionality, the label does not specify an action, and therefore does not need to communicate that further input or confirmation is required.

@kinten108101 kinten108101 added this to the Week 2 milestone Apr 16, 2023
@kinten108101
Copy link
Owner Author

I read the view switcher guideline wrong. The case of "view controls influence other controls in other views" applies only in the Preferences window.

@kinten108101
Copy link
Owner Author

kinten108101 commented Apr 18, 2023

I've changed the names of each stack page to comply with the guideline. However, I have not changed a page icon that needs changing. I was planning to use the app's symbolic there, but currently it's not working (See #40 ). Only the title is our priority. So I'll skip this issue.

@kinten108101 kinten108101 changed the title Update row design to comply with GNOME HIG Update app to comply with GNOME HIG Apr 18, 2023
@kinten108101 kinten108101 removed the feature New addition label Apr 18, 2023
kinten108101 added a commit that referenced this issue Apr 18, 2023
[#35] Update app to comply with GNOME HIG
@kinten108101 kinten108101 linked a pull request Apr 18, 2023 that will close this issue
@kinten108101 kinten108101 self-assigned this Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant