Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline labels aren't being applied #23

Closed
kinto-b opened this issue Nov 12, 2021 · 1 comment · Fixed by #28
Closed

Pipeline labels aren't being applied #23

kinto-b opened this issue Nov 12, 2021 · 1 comment · Fixed by #28
Assignees
@kinto-b
Labels
bug Something isn't working
Milestone
0.1.0

Comments

@kinto-b
Copy link
Owner

kinto-b commented Nov 12, 2021

It's because they're overwritten by the print method:

makepipe/R/Pipeline.R

Lines 220 to 225 in cc4f700

# Label
nodes$label <- ifelse(
nodes$id %in% edges[edges$.recipe, "to"],
"Recipe",
basename(as.character(nodes$id))
)

Should only do this if there are no labels to begin with
@kinto-b kinto-b added the bug Something isn't working label Nov 12, 2021
@kinto-b kinto-b self-assigned this Nov 12, 2021
@kinto-b kinto-b added this to the 0.0.6 milestone Nov 12, 2021
kinto-b added a commit that referenced this issue Nov 16, 2021
@kinto-b
Fix pipeline labelling bug (#23)
312ee44 
 Pipeline labels were being overwritten by the print method
@kinto-b kinto-b linked a pull request Nov 22, 2021 that will close this issue
Segment #28
Merged
@kinto-b
Copy link
Owner Author

kinto-b commented Nov 22, 2021

Will be in next release

@kinto-b kinto-b closed this as completed Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kinto-b kinto-b

Labels
bug Something isn't working
Projects
None yet
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

Segment kinto-b/makepipe
1 participant
@kinto-b