Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support new log event levels (debug and fatal) #473

Merged
merged 3 commits into from
Sep 7, 2023
Merged

feat: Support new log event levels (debug and fatal) #473

merged 3 commits into from
Sep 7, 2023

Conversation

tuanphamcybozu
Copy link
Contributor

Why

  • Support new log event levels: debug and fatal

What

  • Add more new log level to Logger and customize color follow the level

How to test

  • Usage: logger.debug("test message") and logger.fatal("test message")
  • pnpm test

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed pnpm lint and pnpm test on the root directory.

@tuanphamcybozu tuanphamcybozu requested review from a team and hung-cybo and removed request for a team September 7, 2023 05:24
tasshi-me
tasshi-me requested changes Sep 7, 2023
View reviewed changes
Copy link
Member

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!
I added some requests for changes.

src/utils/__tests__/log.test.ts Show resolved Hide resolved
src/utils/__tests__/log.test.ts Outdated Show resolved Hide resolved
src/utils/__tests__/log.test.ts Outdated Show resolved Hide resolved
src/utils/log.ts Show resolved Hide resolved
tasshi-me
tasshi-me approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tasshi-me tasshi-me merged commit 33c4652 into main Sep 7, 2023
10 checks passed
@tasshi-me tasshi-me deleted the feat/support-new-logs-event-level branch September 7, 2023 09:18
This was referenced Sep 7, 2023
Merged
Closed
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Sep 27, 2023
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Oct 4, 2023
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Oct 16, 2023
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Oct 25, 2023
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Nov 1, 2023
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Nov 15, 2023
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Dec 6, 2023
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Dec 27, 2023
Merged
This was referenced Jan 17, 2024
Merged
Merged
This was referenced Jan 31, 2024
Merged
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Feb 21, 2024
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Apr 3, 2024
Merged
This was referenced Jun 12, 2024
Merged
Closed
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Oct 1, 2024
Closed
This was referenced Oct 23, 2024
Merged
Merged
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasshi-me tasshi-me tasshi-me approved these changes

@hung-cybo hung-cybo Awaiting requested review from hung-cybo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuanphamcybozu @tasshi-me