Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: automate setup and tear down for record export #495

Merged
merged 4 commits into from
Sep 22, 2023
Merged

test: automate setup and tear down for record export #495

merged 4 commits into from
Sep 22, 2023

Conversation

tuanphamcybozu
Copy link
Contributor

@tuanphamcybozu tuanphamcybozu commented Sep 21, 2023 •
edited
Loading

Why

What

  • automate setup and tear-down for export command test cases.

How to test

pnpm test:e2e

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added/updated tests if it is required. (or tested manually)
  • Passed pnpm lint and pnpm test on the root directory.

@tuanphamcybozu tuanphamcybozu requested review from a team and hung-cybo and removed request for a team September 21, 2023 05:11
tasshi-me
tasshi-me requested changes Sep 22, 2023
View reviewed changes
features/ultils/helper.ts Outdated Show resolved Hide resolved
tasshi-me
tasshi-me approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tasshi-me tasshi-me merged commit 665c3f1 into main Sep 22, 2023
10 checks passed
@tasshi-me tasshi-me deleted the test/e2e-setup-and-teardown branch September 22, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasshi-me tasshi-me tasshi-me approved these changes

@hung-cybo hung-cybo Awaiting requested review from hung-cybo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuanphamcybozu @tasshi-me @hung-cybo