Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop node16 support #504

Merged
merged 4 commits into from
Oct 3, 2023
Merged

chore: drop node16 support #504

merged 4 commits into from
Oct 3, 2023

Conversation

hung-cybo
Copy link
Contributor

Why

Node v16 is now EOL.

https://nodejs.org/en/blog/announcements/nodejs16-eol

What

  • Drop support for node v16

How to test

N/A

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added/updated tests if it is required. (or tested manually)
  • Passed pnpm lint and pnpm test on the root directory.

@hung-cybo hung-cybo requested review from a team and tuanphamcybozu and removed request for a team September 26, 2023 01:09
Copy link
Member

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tasshi-me tasshi-me changed the title chore: drop node16 support chore!: drop node16 support Oct 3, 2023
@tasshi-me tasshi-me changed the title chore!: drop node16 support chore: drop node16 support Oct 3, 2023
@tasshi-me tasshi-me merged commit 01da128 into main Oct 3, 2023
7 checks passed
@tasshi-me tasshi-me deleted the chore/drop-node16-support branch October 3, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants