Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: resolve release-please-action warning #2550

Merged
merged 1 commit into from
Feb 5, 2024
Merged

ci: resolve release-please-action warning #2550

merged 1 commit into from
Feb 5, 2024

Conversation

hung-cybo
Copy link
Contributor

@hung-cybo hung-cybo commented Feb 4, 2024 •
edited
Loading

Why

  1. release-please use a manifest configuration file by default. Therefore, we do not need to specify the command option.
  2. The behavior of releases_created is changed from v3->v4, ref

What

  • Remove the command option.
  • Update the condition of releases_created

How to test

N/A

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed pnpm lint and pnpm test on the root directory.

@hung-cybo hung-cybo requested review from a team and tuanphamcybozu and removed request for a team February 4, 2024 12:15
tuanphamcybozu
tuanphamcybozu approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@tuanphamcybozu tuanphamcybozu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tuanphamcybozu tuanphamcybozu merged commit 3025b72 into master Feb 5, 2024
9 checks passed
@tuanphamcybozu tuanphamcybozu deleted the ci/resolve-replease-please-warning branch February 5, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuanphamcybozu tuanphamcybozu tuanphamcybozu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hung-cybo @tuanphamcybozu