Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(rest-api-client): modify document corresponding to kintone.dev #2593

Merged
merged 1 commit into from
Feb 28, 2024
Merged

docs(rest-api-client): modify document corresponding to kintone.dev #2593

merged 1 commit into from
Feb 28, 2024

Conversation

tuanphamcybozu
Copy link
Contributor

@tuanphamcybozu tuanphamcybozu commented Feb 28, 2024 •
edited
Loading

Why

  • make unify between kintone.dev and js-sdk docs

What

  • modify space.getSpace() document corresponding to kintone.dev

How to test

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed pnpm lint and pnpm test on the root directory.

@tuanphamcybozu tuanphamcybozu requested review from a team and hung-cybo and removed request for a team February 28, 2024 04:02
@github-actions github-actions bot added the pkg: rest-api-client @kintone/rest-api-client label Feb 28, 2024
@tuanphamcybozu tuanphamcybozu changed the title feat(rest-api-client): modify docs corresponding to kintone.dev docs(rest-api-client): modify doc corresponding to kintone.dev Feb 28, 2024
@hung-cybo hung-cybo changed the title docs(rest-api-client): modify doc corresponding to kintone.dev docs(rest-api-client): modify document corresponding to kintone.dev Feb 28, 2024
hung-cybo
hung-cybo approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@hung-cybo hung-cybo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hung-cybo hung-cybo merged commit 17cc3c8 into master Feb 28, 2024
10 checks passed
@hung-cybo hung-cybo deleted the feat/modify-docs-for-getSpace-method branch February 28, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hung-cybo hung-cybo hung-cybo approved these changes

Assignees
No one assigned
Labels
pkg: rest-api-client @kintone/rest-api-client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuanphamcybozu @hung-cybo