Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rest-api-client): add space.getSpaceMembers() method #2599

Merged
merged 17 commits into from
Mar 8, 2024
Merged

feat(rest-api-client): add space.getSpaceMembers() method #2599

merged 17 commits into from
Mar 8, 2024
+75 −1

Conversation

tuanphamcybozu
Copy link
Contributor

Why

  • Support getSpaceMembers method to be able to get the list of Space Members of a Space.

What

  • Add new method getSpaceMembers
  • Add unit test
  • Add demo script

How to test

  • Check test spec

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed pnpm lint and pnpm test on the root directory.

@tuanphamcybozu tuanphamcybozu requested review from a team and hung-cybo and removed request for a team February 29, 2024 06:35
@github-actions github-actions bot added the pkg: rest-api-client @kintone/rest-api-client label Feb 29, 2024
@github-actions github-actions bot added the pkg: dts-gen @kintone/dts-gen label Mar 1, 2024
@tuanphamcybozu tuanphamcybozu changed the base branch from feat/add-updateSpaceBody-method to master March 3, 2024 01:26
hung-cybo
hung-cybo reviewed Mar 5, 2024
View reviewed changes
Copy link
Contributor

@hung-cybo hung-cybo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a small comment.
Please check it.
Thank you.

packages/rest-api-client/src/client/__tests__/SpaceClient.test.ts Outdated Show resolved Hide resolved
hung-cybo
hung-cybo approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@hung-cybo hung-cybo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tasshi-me
tasshi-me approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tasshi-me
tasshi-me requested changes Mar 7, 2024
View reviewed changes
Copy link
Member

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, we need to resolve conflict.

tasshi-me
tasshi-me approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@tasshi-me tasshi-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tasshi-me tasshi-me merged commit 2c05fa9 into master Mar 8, 2024
10 checks passed
@tasshi-me tasshi-me deleted the feat/add-getSpaceMembers-method branch March 8, 2024 04:53
@trigger-github-actions-release trigger-github-actions-release bot mentioned this pull request Mar 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasshi-me tasshi-me tasshi-me approved these changes

@hung-cybo hung-cybo hung-cybo approved these changes

Assignees
No one assigned
Labels
pkg: dts-gen @kintone/dts-gen pkg: rest-api-client @kintone/rest-api-client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuanphamcybozu @tasshi-me @hung-cybo