fix(plugin-uploader): pin puppeteer version to v8 #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaki-yama
requested review from
a team,
b4h0-c4t and
tasshi-me
and removed request for
a team
zaki-yama
changed the title
zaki-yama
changed the title
|
LGTM 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fix #886.
It's just a temporary measure and we need to solve the actual cause of the problem,
but it seems to take a little time.
So I temporarily pinned the puppeteer version to v8, in which plugin-uploader works fine.
What
Pinned the puppeteer version to v8.
How to test
Checklist
yarn lintandyarn teston the root directory.