Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle metadata values properly #7

Closed
kinverarity1 opened this issue Jul 17, 2015 · 2 comments
Closed

Handle metadata values properly #7

kinverarity1 opened this issue Jul 17, 2015 · 2 comments
Assignees
@kinverarity1
Labels
bug enhancement

Comments

@kinverarity1
Copy link
Owner

At the moment metadata values are not handled very well at all:

  1. It doesn't properly or consistently have default values
  2. Although they can be consistently accessed via their mnemonics in the relevant sections, I haven't decided how to present them as top level properties -- via a "pretty" name or via their mnemonic? And does the library return only their value, or the parent mutable named tuple?
@kinverarity1 kinverarity1 self-assigned this Jul 23, 2015
@kinverarity1
Copy link
Owner Author

Point 1 was addressed some time ago with DEFAULT_ITEMS in las.py (c9d6388).

Point 2 will be addressed with PR #106 to be merged soon.

@kinverarity1
Copy link
Owner Author

For reference, point 2 is now handled cleanly via SectionItems.__setitem__ and SectionItems.set_item_value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kinverarity1 kinverarity1

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kinverarity1