Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EEP.xml #95

Closed
wants to merge 9 commits into from
Closed

Update EEP.xml #95

wants to merge 9 commits into from

Conversation

acutaia
Copy link

@acutaia acutaia commented Apr 26, 2019

Add:
D2-01-09: CMD 0x1
D2-01-09: CMD 0x3
D2-01-09: CMD 0x4
D2-01-09: CMD 0x5
D2-01-09: CMD 0x6
D2-01-09: CMD 0x7

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 91.406% when pulling 36c2108 on Angeloxx92:master into 99fa03f on kipe:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 91.406% when pulling 36c2108 on Angeloxx92:master into 99fa03f on kipe:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 91.406% when pulling 36c2108 on Angeloxx92:master into 99fa03f on kipe:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 91.406% when pulling 36c2108 on Angeloxx92:master into 99fa03f on kipe:master.

@coveralls
Copy link

coveralls commented Apr 26, 2019

Coverage Status

Coverage remained the same at 91.332% when pulling 391abbc on Angeloxx92:master into 99fa03f on kipe:master.

Copy link
Owner

@kipe kipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, looks good! 👍
I added some changes and comments, to be honest even I have no idea on how this VLD telegram stuff works anymore. Not sure if the command identifiers are required, besides the <command> -tags.

What device are you using, seems very interesting :)

enocean/protocol/EEP.xml Outdated Show resolved Hide resolved
enocean/protocol/EEP.xml Outdated Show resolved Hide resolved
enocean/protocol/EEP.xml Outdated Show resolved Hide resolved
enocean/protocol/EEP.xml Outdated Show resolved Hide resolved
enocean/protocol/EEP.xml Outdated Show resolved Hide resolved
enocean/protocol/EEP.xml Outdated Show resolved Hide resolved
enocean/protocol/EEP.xml Outdated Show resolved Hide resolved
enocean/protocol/EEP.xml Outdated Show resolved Hide resolved
@acutaia
Copy link
Author

acutaia commented Apr 26, 2019

i'm using
PERMUNDO DATA_SHEET.pdf

this plug use all of that command and it could also act as a gateway

@acutaia
Copy link
Author

acutaia commented Apr 26, 2019

Yes, we need command identifier cause some device use more than 1 command

@kipe
Copy link
Owner

kipe commented Apr 26, 2019

Hmm, then I think we need some more parsing in the Packet.parse, to add the information. Something like setting self.CMD based on the <command> -tags to get a reasonable output.

That really isn't something for this PR though.

@acutaia
Copy link
Author

acutaia commented Apr 26, 2019

Yeah, i know , infact i'll work on that in the next days cause i have to do this for my Project.
But i also think that maybe other people could find that interesting

@acutaia
Copy link
Author

acutaia commented Apr 26, 2019

Howewer , some command's are for packet response , other are send from the gateway to the plug,so if i send a packet to the plug, i'll know what command will response

@kipe
Copy link
Owner

kipe commented Apr 26, 2019

The CMD should still be included, in case the replies are mixed in with other, timed messages from the plug...
I think this PR is good as it is, but please open a new PR if you figure out a proper way to handle CMD for incoming messages while playing around with the plug. I think I'll order some of those as well, they seem very interesting :)

@acutaia
Copy link
Author

acutaia commented Apr 26, 2019

Sure, i'll do that cause it will be a part of my work project during the stage i'm doing inside a company. It will bea matter of time . See you ;)

kipe and others added 8 commits April 26, 2019 21:33
Co-Authored-By: Angeloxx92 <48996402+Angeloxx92@users.noreply.github.com>
Co-Authored-By: Angeloxx92 <48996402+Angeloxx92@users.noreply.github.com>
Co-Authored-By: Angeloxx92 <48996402+Angeloxx92@users.noreply.github.com>
Co-Authored-By: Angeloxx92 <48996402+Angeloxx92@users.noreply.github.com>
Co-Authored-By: Angeloxx92 <48996402+Angeloxx92@users.noreply.github.com>
Co-Authored-By: Angeloxx92 <48996402+Angeloxx92@users.noreply.github.com>
Co-Authored-By: Angeloxx92 <48996402+Angeloxx92@users.noreply.github.com>
Co-Authored-By: Angeloxx92 <48996402+Angeloxx92@users.noreply.github.com>
@acutaia acutaia closed this Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants