fix some float/int mismatch errors #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maweki
changed the title
|
Thank you for this fix! And you're right, we will have to make tons of this kind of fixes. |
cydanil
pushed a commit
that referenced
this pull request
Jun 6, 2020
Sync with thinkle/gourmet master branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In python2
/was integer division if both operands were integer. In python3,/is always float division. This fixes some errors, but we probably have to do this at a lot of other points in the codebase as well. But this is probably the solution for most errors involving float/int mismatch at some point in the call chain.