-
-
Notifications
You must be signed in to change notification settings - Fork 74
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: use animated reaction instead of derivation (#255)
## 📜 Description <!-- Describe your changes in detail --> ## 💡 Motivation and Context this is more or less a stylistic change, the `useAnimatedReaction` hook is better suited for this than `useDerivedValue` which is supposed to derive a value, but not have side effects ## 📢 Changelog not needed I guess? ## 🤔 How Has This Been Tested? I ran this on an Android 10 device (huawei) and it works the same as before. I used the 'Aware scroll view' example to test this out and I have to say that, unfortuantely, on my device the animation is not (and was not) smooth. That's a different problem though, I might try to open a PR for that later. ## 📸 Screenshots (if appropriate): <!-- Add screenshots/video if needed --> <!-- That would be highly appreciated if you can add how it looked before and after your changes --> ## 📝 Checklist - [ ] CI successfully passed
- Loading branch information
Showing
2 changed files
with
34 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters