fix: better horizontal UIScrollView detection
#454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Package size report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Improved conditions for detecting horizontal
ScrollViewon iOS.💡 Motivation and Context
If we compare
heightproperties, then we may have a false positive case ifScrollViewis not big enough and can not be actually scrolled because of its small size:To fix the problem I decided to compare
widthproperty to properly detect horizontalScrollView.Closes #453
📢 Changelog
iOS
widthproperty to detect horizontalScrollViews;🤔 How Has This Been Tested?
Tested manually on iPhone 15 Pro (iOS 17.4).
📸 Screenshots (if appropriate):
334535791-81c12237-82bd-4995-b657-424ea6a98829.mp4
📝 Checklist