Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix KeyboardAware types in BottomSheet integration section #465

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

kirillzyusko
Copy link
Owner

@kirillzyusko kirillzyusko commented Jun 7, 2024

📜 Description

Added missing memo import + fixed props compatibility.

💡 Motivation and Context

It is very frustrating when you copy&paste code, but it doesn't work straight away.

📢 Changelog

Docs

  • added missing memo import;
  • allow to use KeyboardAwareScrollViewProps on BottomSheet wrapper;

🤔 How Has This Been Tested?

Tested in code + preview.

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

@kirillzyusko kirillzyusko added documentation Improvements or additions to documentation KeyboardAwareScrollView 📜 Anything related to KeyboardAwareScrollView component labels Jun 7, 2024
@kirillzyusko kirillzyusko self-assigned this Jun 7, 2024
Copy link
Contributor

github-actions bot commented Jun 7, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://kirillzyusko.github.io/react-native-keyboard-controller/pr-preview/pr-465/
on branch gh-pages at 2024-06-07 20:20 UTC

Copy link

argos-ci bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 1 changed Jun 7, 2024, 8:21 PM

@kirillzyusko kirillzyusko marked this pull request as ready for review June 10, 2024 08:41
@kirillzyusko kirillzyusko merged commit 8249e48 into main Jun 10, 2024
9 checks passed
@kirillzyusko kirillzyusko deleted the docs/fix-keyboard-aware-types-in-bottom-sheet branch June 10, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation KeyboardAwareScrollView 📜 Anything related to KeyboardAwareScrollView component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant