Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify network layer #175

Merged
merged 23 commits into from
Nov 5, 2023
Merged

Simplify network layer #175

merged 23 commits into from
Nov 5, 2023

Conversation

kirmanak
Copy link
Owner

@kirmanak kirmanak commented Oct 29, 2023 •
edited
Loading

This PR simplifies the network layer in three ways:

  1. Replaces Retrofit with Ktor.
  2. Removes support for older Mealie APIs (such as 0.5.6).
  3. Removes now unnecessary *Info objects

@kirmanak
Use Ktor for network requests
ec9bec7
@kirmanak
Remove V0 version
ed57df1
@kirmanak
Remove Retrofit dependency
8278e82
@kirmanak
Fix url
81e9ac9
@kirmanak
Update versions of dependencies
bc3ab22
@kirmanak
Revert kotlinx-datetime
fde0f83 
Due to Kotlin/kotlinx-datetime#304
@kirmanak
Rename leftovers
62fba76
@kirmanak
Remove OkHttp
617b529
@kirmanak
Remove unused manifest
d826ba5
@kirmanak
Remove unused Hilt module
6ecdba7
@kirmanak
Fix building empty image URLs
d01bfbb
@kirmanak
Use OkHttp as engine for Ktor
b89bea6
@kirmanak
Reduce visibility of internal classes
148f0e3
@kirmanak
Fix first set up test
aeab503
@kirmanak
Store only auth token, not header
0a1c5c8
@kirmanak
Remove UnitInfo/FoodInfo/VersionInfo/NewShoppingListItemInfo
95b6a06
@kirmanak
Remove RecipeSummaryInfo and ShoppingListsInfo
c776878
@kirmanak
Remove FullShoppingListInfo
9912073
@kirmanak
Remove ParseRecipeURLInfo
16a5e35
@kirmanak
Remove FullRecipeInfo
bdd9c59
@kirmanak
Sign out if access token does not work
bcd8de5
@kirmanak
Rename getVersionInfo method
a65ca71
@kirmanak
Update version name
810c0a7
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@kirmanak kirmanak merged commit 5ed1acb into master Nov 5, 2023
4 of 5 checks passed
@kirmanak kirmanak deleted the ktor branch November 5, 2023 14:01
@Slater91 Slater91 mentioned this pull request Dec 7, 2023
Closed
@kirmanak kirmanak mentioned this pull request Dec 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kirmanak