Converted snake_case identifiers to idiomatic go camelCase. A few other minor changes. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mboxs key events handler to tty draw update.
…ts methods into tis file.
| @@ -425,6 +426,7 @@ func (e *editor) Loop() error { | |||
|
|
|||
| e.draw() | |||
| termbox.Flush() | |||
| time.Sleep(10 * time.Millisecond) | |||
There was a problem hiding this comment.
Not sure what this does, can we keep it out for now? I don't want to start tweaking any of the drawing code at this point.
|
Thanks for taking the time to do this, will merge it once the comments above are fixed. |
|
All the changes you asked for are done. |
kisielk
added a commit
that referenced
this pull request
Apr 22, 2013
Converted snake_case identifiers to idiomatic go camelCase. A few other minor changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also unexported all the identifiers because eventually we might end up pulling some of the code out to expose in an API pkg. This will help avoid confusion later. Besides there is no reason to export identifiers in a non importable pkg anyways.
Also I added a sleep(10 * time.Millisecond) in the termbox loop right after we flush the buffer to smooth out the cursor keystroke.