Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timestamp_ms() truncates on python 2 #25

Closed
tommyolofsson opened this issue Oct 11, 2016 · 1 comment
Closed

timestamp_ms() truncates on python 2 #25

tommyolofsson opened this issue Oct 11, 2016 · 1 comment

Comments

@tommyolofsson
Copy link
Contributor

tommyolofsson commented Oct 11, 2016 •
edited
Loading

Different resolution on python 2 and 3 since 0.12.0. Not sure if this is intentional.
@Don42
Copy link
Contributor

Don42 commented Oct 10, 2018

That is not intentional. This bug was introduced when I fixed #12.
I'm going to create a PR to fix this. I'm only running code on py3 and forgot the difference.

Don42 added a commit to Don42/pypcapfile that referenced this issue Oct 10, 2018
@Don42
Fix timestamp division on py2
4146bbb 
Calculating the millisecond timestamp was only tested on py3.
On py2 the integer division caused the value to be truncated.

Fixes kisom#25
@kisom kisom closed this as completed in 2eef972 Oct 10, 2018
@Don42 Don42 mentioned this issue Oct 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Don42 @tommyolofsson