Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZipReader unpacks in ./temp #56

Closed
2 tasks
Pfeil opened this issue Sep 6, 2022 · 0 comments · Fixed by #83
Closed
2 tasks

ZipReader unpacks in ./temp #56

Pfeil opened this issue Sep 6, 2022 · 0 comments · Fixed by #83
Assignees
Labels
bug Something isn't working code quality Mostly internal changes to improve the code quality. question Further information is requested

Comments

@Pfeil
Copy link
Member

Pfeil commented Sep 6, 2022

  • should be unpacked in subfolder so different imported crates do not interfere
  • the content should be removed at some point, currently it is "on java exit"? Question is who is responsible for deletion. The reader may create a Crate Object, and it does not directly have a relation to the folder. So, as soon as one (or multiple) crates have been created, it is not anymore in the readers responsibility. We need to add some control on this, I think, and we need to see which possibilities we have in Java. Thoughts:
    • Recently we fixed an issue that a reader can not be used multiple times to read a crate. This might have been on purpose, though? Is this why the content is being deleted so late, because now the reader can live so long? @Code42Cate
    • Responsibility could be given by some kind of file lock, which is initially at the reader, and then at the exported crate. Further crates on the same folder then can not be created.
@Pfeil Pfeil added bug Something isn't working question Further information is requested code quality Mostly internal changes to improve the code quality. labels Sep 6, 2022
@Pfeil Pfeil changed the title ZipReader unpacks in /tmp, not in subfolder ZipReader unpacks in ./temp, not in subfolder Sep 6, 2022
@Pfeil Pfeil changed the title ZipReader unpacks in ./temp, not in subfolder ZipReader unpacks in ./temp Sep 6, 2022
@Pfeil Pfeil added this to the v1.1.1 milestone Jul 25, 2023
@Pfeil Pfeil removed this from the v1.1.1 milestone Aug 21, 2024
@Pfeil Pfeil self-assigned this Sep 12, 2024
@Pfeil Pfeil linked a pull request Sep 13, 2024 that will close this issue
@Pfeil Pfeil closed this as completed Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code quality Mostly internal changes to improve the code quality. question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant