Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support java overloading #65

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Conversation

ahaostudy
Copy link
Collaborator

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

feat: 支持 java 重载

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

Fixes #60

(optional) The PR that updates user documentation:

pkg/codec.go Outdated Show resolved Hide resolved
pkg/codec.go Outdated Show resolved Hide resolved
pkg/codec.go Outdated Show resolved Hide resolved
pkg/codec.go Outdated Show resolved Hide resolved
pkg/codec.go Outdated Show resolved Hide resolved
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ahaostudy, felix021
To complete the pull request process, please assign yangruiemma after the PR has been reviewed.
You can assign the PR to them by writing /assign @yangruiemma in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DMwangnima DMwangnima merged commit f9aec65 into kitex-contrib:main Nov 14, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: support java overloading (same method name with different arguments)
3 participants