Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement interface-level registry-zookeeper service registry #67

Merged
merged 28 commits into from
Nov 17, 2023

Conversation

DMwangnima
Copy link
Collaborator

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

registries/common.go Outdated Show resolved Hide resolved
registries/common.go Outdated Show resolved Hide resolved
@felix021
Copy link
Contributor

Add a comment to pause bot notice.

Notify me after new push.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DMwangnima, felix021
To complete the pull request process, please assign jasondeng1997 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jasondeng1997 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@felix021 felix021 merged commit 22694e0 into kitex-contrib:main Nov 17, 2023
10 of 11 checks passed
@DMwangnima DMwangnima deleted the dev-zookeeper_register branch December 18, 2023 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants