Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata validation should also check for validity of parent processes #5280

Open
BartChris opened this issue Aug 5, 2022 · 3 comments
Open
Labels
feature ruleset ruleset functions and configuration

Comments

@BartChris
Copy link
Collaborator

BartChris commented Aug 5, 2022

Describe the bug
When closing a task one can setup to validate the metadata before the task is closed. (See #2731).
The validity check should probably be extended to all parent processes. Otherwise one can export a process and the export of the parent process will fail because of invalid metadata. This problem is increased by the fact that in case of a failed validation during export the whole process does not stop although no valid metadata is exported and the next workflow steps depending on the exported METS will fail. (see #5008)

Expected behavior
A process should not be considered valid until the parent process is valid. At least in the case of a automatic check when the task gets closed.

Please specify the version of Kitodo.Production in which the bug was encountered
3.4.4-SNAPSHOT

@BartChris
Copy link
Collaborator Author

BartChris commented Aug 12, 2022

Labelling it as a feature is probably more correct. I see the main problem that the workflow is continued after the export even if an exception might occur here because of invalid process data.
This could lead to all kinds of problems, similar to an export of unchecked image info descibed in: #5282 (comment)

@matthias-ronge
Copy link
Collaborator

Our definition—or at least, mine—for a “feature” is “something we never had before”. The new design of the issue input page here on GitHub now has automatically started tagging new issues as “bug”, so I changed that.

@matthias-ronge matthias-ronge added the ruleset ruleset functions and configuration label Feb 28, 2023
@matthias-ronge
Copy link
Collaborator

The proposal is difficult. What does an employee, who has taken on the metadata task, but cannot complete the task because the higher-level process has errors? However, the employee has no task for the higher-level process, so he cannot do anything here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ruleset ruleset functions and configuration
Projects
None yet
Development

No branches or pull requests

2 participants