Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tt_nano_HAT wrong board showcase #420

Closed
AbdulrhmnGhanem opened this issue Sep 27, 2022 · 6 comments
Closed

tt_nano_HAT wrong board showcase #420

AbdulrhmnGhanem opened this issue Sep 27, 2022 · 6 comments
Labels
bug Something isn't working import-v1-projects
Milestone

Comments

@AbdulrhmnGhanem
Copy link
Member

AbdulrhmnGhanem commented Sep 27, 2022

https://github.com/vektorious/test_tube_photometer

v1 v2
image image
@AbdulrhmnGhanem
Copy link
Member Author

@kasbah, what should be the behavior for this?
The paths for the gerbers aren't specified. so it uses the folder with the most gerbers. In v1 the folders to search in are limited by the sub project name.

multi:
  tt_nano_HAT_b1:
    summary: Test Tube Photometer Arduino Nano HAT - Version 1
    readme: hardware/pcb/README.md
    bom: hardware/pcb/tt_nano_HAT_b1/1-click-bom.csv
    eda:
      type: kicad
      pcb: hardware/pcb/tt_nano_HAT_b1/tt_nano_HAT_b1.kicad_pcb
  tt_nano_HAT_b2:
    summary: Test Tube Photometer Arduino Nano HAT - Version 2
    readme: hardware/pcb/README.md
    bom: hardware/pcb/tt_nano_HAT_b2/1-click-bom.csv
    eda:
      type: kicad
      pcb: hardware/pcb/tt_nano_HAT_b2/tt_nano_HAT_b2.kicad_pcb
  tt_opt101_module:
    summary: Test Tube Photometer opt101 module.
    readme: hardware/pcb/README.md
    bom: hardware/pcb/tt_opt101_module_b1/tt_opt101_module_b1.kicad_pcb
    eda:
      type: kicad
      pcb: hardware/pcb/tt_opt101_module_b1/tt_opt101_module_b1.kicad_pcb

@AbdulrhmnGhanem
Copy link
Member Author

AbdulrhmnGhanem commented Sep 29, 2022

Related to #362.

@kasbah
Copy link
Member

kasbah commented Sep 29, 2022

v2 behaviour is the correct way moving forward, we'll have to update kitspace.yaml for individual projects.

@AbdulrhmnGhanem
Copy link
Member Author

Fixed via #458.

@kasbah
Copy link
Member

kasbah commented Nov 8, 2022

Is it using all the right files now or do we need to send a PR to update the project's kitspace.yaml as well?

@kasbah kasbah reopened this Nov 8, 2022
@AbdulrhmnGhanem
Copy link
Member Author

Everything is OK!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working import-v1-projects
Projects
None yet
Development

No branches or pull requests

2 participants